linux-kernel - Re: [PATCH] Fix Oops in crash_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100610142622.497061e8.akpm@linux-foundation.org>
Date:	Thu, 10 Jun 2010 14:26:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Pavan Naregundi <pavan@...ux.vnet.ibm.com>
Cc:	Simon Horman <horms@...ge.net.au>,
	Américo Wang <xiyou.wangcong@...il.com>,
	linux-kernel@...r.kernel.org, vgoyal@...hat.com, hbabu@...ibm.com,
	kexec@...ts.infradead.org
Subject: Re: [PATCH] Fix Oops in crash_shrink_memory

On Wed, 09 Jun 2010 11:57:14 +0530
Pavan Naregundi <pavan@...ux.vnet.ibm.com> wrote:

> Resending the patch with fixed style issues.
> 
> Signed-off-by: Pavan Naregundi <pavan@...ux.vnet.ibm.com>
> Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>
> --
> 
> 
> 
> 
> [fix-kexec.patch  text/x-patch (685B)]
> diff -Naur a/kernel/kexec.c b/kernel/kexec.c
> --- a/kernel/kexec.c	2010-06-08 21:17:21.850000033 +0530
> +++ b/kernel/kexec.c	2010-06-09 18:01:37.590007921 +0530
> @@ -1089,9 +1089,10 @@
>  
>  size_t crash_get_memory_size(void)
>  {
> -	size_t size;
> +	size_t size = 0;
>  	mutex_lock(&kexec_mutex);
> -	size = crashk_res.end - crashk_res.start + 1;
> +	if (crashk_res.end != crashk_res.start)
> +		size = crashk_res.end - crashk_res.start + 1;
>  	mutex_unlock(&kexec_mutex);
>  	return size;
>  }
> @@ -1134,7 +1135,7 @@
>  
>  	free_reserved_phys_range(end, crashk_res.end);
>  
> -	if (start == end)
> +	if ((start == end) && (crashk_res.parent != NULL))
>  		release_resource(&crashk_res);
>  	crashk_res.end = end - 1;

The patch doesn't have a changelog and I'd prefer not to have to crawl
through the email thread and write one myself.

Please resend, including a full description of the bug and of its fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/