linux-kernel - Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006102231.AA00429@tamuki.linet.gr.jp>
Date:	Fri, 11 Jun 2010 07:31:13 +0900
From:	TAMUKI Shoichi <tamuki@...et.gr.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Anton Blanchard <anton@...ba.org>,
	Andi Kleen <andi@...stfloor.org>,
	Andy Green <andy@...mcat.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	TAMUKI Shoichi <tamuki@...et.gr.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode

Hello,

On Wed, 9 Jun 2010 15:15:52 -0700 Andrew Morton wrote:

> Morse code?  Kidding?

I'm sorry, I'm confusing you.

> Sorry, no.  Nobody who uses this feature will know what what
> "words per minute" means.  It's nutty!

That is just a strained interpretation where the measure of the
blinking speed comes from.  The description of "words per minute"
has already disappeared in the latest patch.

> Please remind me why we're making this configurable at all.  Can't we
> just hardwire the thing to 1Hz or something?  Add an
> im_using_a_hypervisor boot option or something, if necessary?

For now, gta02_panic_blink(), one of panic_blink() users, expects a
10Hz call rate.  IOW, it blinks at 5Hz (i.e. panicblink=36).  I think
that the desirable blinking speed is different according to devices.

Regards,
TAMUKI Shoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/