linux-kernel - Re: [PATCH] Marvell OpenRD-Ultimate machine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Jun 2010 09:15:24 +0300
From:	Dmytro Milinevskyy <milinevskyy@...il.com>
To:	Alexander Clouter <alex@...riz.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Dhaval Vasa <dhaval.vasa@...fochips.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Simon Guinot <sguinot@...ie.com>,
	Martin Michlmayr <tbm@...ius.com>,
	Simon Kagstrom <simon.kagstrom@...insight.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Marvell OpenRD-Ultimate machine support

Hi!

You are right, I didn't notice that it's called via subsys_initcall.

-- Dima

On Thu, Jun 10, 2010 at 8:50 AM, Alexander Clouter <alex@...riz.org.uk> wrote:
> Hi,
>
> * Dmytro Milinevskyy <milinevskyy@...il.com> [2010-06-10 05:24:56+0300]:
>>
>> [snipped]
>>
>> @@ -84,8 +90,7 @@ static void __init openrd_init(void)
>>
>>  static int __init openrd_pci_init(void)
>>  {
>> -     if (machine_is_openrd_base() || machine_is_openrd_client())
>> -             kirkwood_pcie_init();
>> +     kirkwood_pcie_init();
>>
>>       return 0;
>>  }
>>
> You just 'broke' kirkwood, welcome to the club.  We all have done this:
>
> http://marc.info/?l=linux-arm-kernel&m=125624586625065&w=2
> http://marc.info/?l=linux-arm-kernel&m=125804222219159&w=2
>
> Put that 'if()' clause back in, the 'subsys_initcall(openrd_pci_init)'
> causes that code to run on *all* compiled in boards (think of the case
> where you have SheevaPlug's also enabled).
>
> Cheers
>
> --
> Alexander Clouter
> .sigmonster says: Poverty begins at home.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/