linux-kernel - Re: [PATCH 1/4 V2] [tip:x86/mm] Correcting improper large page preservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinkhXQfE9Ejcb3dJeMZWl6gxbO3-gzqPUBxei4N@mail.gmail.com>
Date:	Thu, 10 Jun 2010 22:11:38 -0400
From:	Siarhei Liakh <sliakh.lkml@...il.com>
To:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-next@...r.kernel.org
Cc:	Arjan van de Ven <arjan@...radead.org>,
	James Morris <jmorris@...ei.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@....de>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 1/4 V2] [tip:x86/mm] Correcting improper large page 
	preservation

On Sun, Jun 6, 2010 at 9:00 PM, Siarhei Liakh <sliakh.lkml@...il.com> wrote:
> This patch fixes a bug in try_preserve_large_page() which may result
> in improper large page preservation and improper application of page
> attributes to the memory area outside of the original change request.
> More specifically, the problem manifests itself when set_memory_*() is
> called for several pages at the beginning of the large page and
> try_preserve_large_page() erroneously concludes that the change can be
> applied to whole large page.
> The fix consists of 3 parts:
> 1. addition of "required" protection attributes in
> static_protections(), so .data and .bss can be guaranteed to stay "RW"
> 2. static_protections() is now called for every small page within
> large page to determine compatibility of new protection attributes
> (instead of just small pages within the requested range).
> 3. large page can be preserved only if attribute change is
> large-page-aligned and covers whole large page.
>
> V1:  try_preserve_large_page() patch for Linux 2.6.34-rc2
> V2:  replaced pfn check with address check for kernel rw-data
>
> Signed-off-by: Siarhei Liakh <sliakh.lkml@...il.com>
> Signed-off-by: Xuxian Jiang <jiang@...ncsu.edu>
> Reviewed-by: Suresh Siddha <suresh.b.siddha@...el.com>
> ---

Does anyone have any feedback on this patch set?

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/