lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Jun 2010 17:12:54 -0700 From: David Daney <ddaney@...iumnetworks.com> To: Himanshu Chauhan <hschauhan@...ltrace.org> CC: ralf@...ux-mips.org, linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org Subject: Re: [PATCH] MIPS: KProbes support v0.1 On 06/08/2010 10:51 AM, Himanshu Chauhan wrote: > Hi David, > > Thanks for taking a look. > [...] >>> + >>> +#define BREAKPOINT_INSTRUCTION 0x0000000d >>> + >>> +/* >>> + * We do not have hardware single-stepping on MIPS. >>> + * So we implement software single-stepping with breakpoint >>> + * trap 'break 5'. >>> + */ >>> +#define BREAKPOINT_INSTRUCTION_2 0x0000014d >> >> The BREAK codes are defined in asm/break.h This should be added >> there instead. >> >> Why do you use codes (0 and 5) that are already kind of reserved for >> user space debuggers? > > As said ealier, this patch was based on some very older patch of 2.6.16 from > Sony Corp, I didn't make much changes like this. But anyways, I wan't aware of > this either. What would be the best code then? > How about allocating them after BRK_MEMU? Say 515 and 516 or something like that. David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists