linux-kernel - Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jun 2010 07:56:01 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Tom Lyon <pugs@...n-about.com>
CC:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	randy.dunlap@...cle.com, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, chrisw@...s-sol.org, joro@...tes.org,
	hjk@...utronix.de, mst@...hat.com, gregkh@...e.de,
	aafabbri@...co.com, scofeldm@...co.com
Subject: Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

On 06/11/2010 04:58 AM, Tom Lyon wrote:
> On Thursday 10 June 2010 10:27:36 am Konrad Rzeszutek Wilk wrote:
>    
>>> +EXPORT_SYMBOL(uiommu_fdget);
>>>        
>> EXPORT_SYMBOL_GPL
>> .. snip
>>      
>>> +EXPORT_SYMBOL(uiommu_put);
>>>        
>> ditto.
>>
>>      
> Is there a definitive explanation somewhere of when to use each?
>    

Always use _GPL unless you have a defensible reason why you shouldn't.  
The kernel's license if GPL, exporting a symbol without GPL can be seen 
as adding an exception to the license.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/