linux-kernel - Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinA0cEXRVtD8iP1UhOsdYsSRONagfX7yQbMl_DG@mail.gmail.com>
Date:	Sat, 12 Jun 2010 05:02:53 +0300
From:	Dmytro Milinevskyy <milinevskyy@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Bob Copeland <me@...copeland.com>, ath5k-devel@...ts.ath5k.org,
	Kalle Valo <kalle.valo@....fi>, linux-wireless@...r.kernel.org,
	GeunSik Lim <geunsik.lim@...sung.com>,
	Jiri Slaby <jirislaby@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"John W. Linville" <linville@...driver.com>,
	Keng-Yu Lin <keng-yu.lin@...onical.com>,
	netdev@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Shahar Or <shahar@...har-or.co.il>,
	linux-kernel@...r.kernel.org, Luca Verdesca <magooz@...ug.it>
Subject: Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds 
	support. If leds support enabled do not force mac802.11 leds layer selection.

In this case no way to control LEDs. If you turn LEDs support you
can't tune them out, no?

I believe that user should be able to chose whether LEDs support is
needed or not. This is how done in intel wireless drivers. The driver
should be tolerant.

-- Dima

On Fri, Jun 11, 2010 at 11:29 PM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Fri, 2010-06-11 at 23:26 +0300, Dmytro Milinevskyy wrote:
>> Generic LED class is not disabled so it's possible to control leds in sysfs.
>
> But if you turn off ATH5K_LEDS??
>
> johannes
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/