linux-kernel - Re: [PATCH 1/2] gpio: msm7200a: Add gpiolib support for MSM chips.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C12F218.9010808@codeaurora.org>
Date:	Fri, 11 Jun 2010 19:34:00 -0700
From:	Bryan Huntsman <bryanh@...eaurora.org>
To:	Ben Dooks <ben-linux@...ff.org>
CC:	Gregory Bean <gbean@...eaurora.org>, akpm@...ux-foundation.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>,
	"David S. Miller" <davem@...emloft.net>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Mike Frysinger <vapier@...too.org>,
	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...eaurora.org>
Subject: Re: [PATCH 1/2] gpio: msm7200a: Add gpiolib support for MSM chips.

Ben Dooks wrote:
> On Fri, Jun 11, 2010 at 12:58:51PM -0700, Gregory Bean wrote:

...snip...

>> +MODULE_DESCRIPTION("Driver for Qualcomm MSM 7200a-family SoC GPIOs");
>> +MODULE_LICENSE("GPLv2");
> 
> you left out a MODULE_ALIAS() for your platform device.
> you could also do with a MODULE_AUTHOUR() line as well

Also, the string is "GPL v2".  See include/linux/license.h.

>> diff --git a/include/linux/msm7200a-gpio.h b/include/linux/msm7200a-gpio.h
>> new file mode 100644
>> index 0000000..3f1ef38
>> --- /dev/null
>> +++ b/include/linux/msm7200a-gpio.h
>> @@ -0,0 +1,44 @@
>> +/* Copyright (c) 2010, Code Aurora Forum. All rights reserved.
>> + *
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions are
>> + * met:
>> + *     * Redistributions of source code must retain the above copyright
>> diff --git a/include/linux/msm7200a-gpio.h b/include/linux/msm7200a-gpio.h
>> new file mode 100644
>> index 0000000..3f1ef38
>> --- /dev/null
>> +++ b/include/linux/msm7200a-gpio.h
>> @@ -0,0 +1,44 @@
>> +/* Copyright (c) 2010, Code Aurora Forum. All rights reserved.
>> + *
>> + * Redistribution and use in source and binary forms, with or without
> ;5B> + * modification, are permitted provided that the following conditions are
>> + * met:
>> + *     * Redistributions of source code must retain the above copyright
>> + *       notice, this list of conditions and the following disclaimer.
>> + *     * Redistributions in binary form must reproduce the above
>> + *       copyright notice, this list of conditions and the following
>> + *       disclaimer in the documentation and/or other materials provided
>> + *       with the distribution.
>> + *     * Neither the name of Code Aurora Forum, Inc. nor the names of its
>> + *       contributors may be used to endorse or promote products derived
>> + *       from this software without specific prior written permission.
>> + *
>> + * THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED
>> + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
>> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT
>> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS
>> + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
>> + * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
>> + * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
>> + * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN
>> + * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> + *
>> + */
> 
> Is this really GPL compatible?

It's BSD-style, so yes.


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/