linux-kernel - Re: [PATCH 1/2] Remove preempt_enable/disable calls around sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100613100121.GC12322@elte.hu>
Date:	Sun, 13 Jun 2010 12:01:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Divyesh Shah <dpshah@...gle.com>
Cc:	jaxboe@...ionio.com, peterz@...radead.org, piotr@...owicz.com,
	linux-kernel@...r.kernel.org, vgoyal@...hat.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] Remove preempt_enable/disable calls around
 sched_clock()


* Divyesh Shah <dpshah@...gle.com> wrote:

> On Sat, Jun 12, 2010 at 12:19 AM, Ingo Molnar <mingo@...e.hu> wrote:
> >
> > * Divyesh Shah <dpshah@...gle.com> wrote:
> >
> >> calls in the block layer. This was a temporary fix added.
> >
> > Not good, this commit reintroduces those ugly warnings, if someone happens to
> > bisect straight into this commit.
> 
> You're right. In the next version, I'll merge both patches into one so
> this cannot happen.

Yeah - or if you really want to make a point of doing the two things in two 
separate patches you can first fix the API, _then_ remove the preemption 
enable/disable.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/