linux-kernel - Re: [PATCH] Staging: comedi: drivers: fix coding style issues in pcl812.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jun 2010 11:13:25 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Gustavo Silva <silvagustavosilva@...il.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"wfp5p@...ginia.edu" <wfp5p@...ginia.edu>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"silvagustavo@...rs.sourceforge.net" 
	<silvagustavo@...rs.sourceforge.net>
Subject: Re: [PATCH] Staging: comedi: drivers: fix coding style issues in
 pcl812.c

On 13/06/10 04:25, Gustavo Silva wrote:
> + * Driver: pcl812
> + * Description: Advantech PCL-812/PG, PCL-813/B,
> + *          ADLink ACL-8112DG/HG/PG, ACL-8113, ACL-8216,
> + *          ICP DAS A-821PGH/PGL/PGL-NDA, A-822PGH/PGL, A-823PGH/PGL, A-826PG,
> + *          ICP DAS ISO-813
> + * Author: Michal Dobes <dobes@...net.cz>
> + * Devices: [Advantech] PCL-812 (pcl812), PCL-812PG (pcl812pg),
> + * PCL-813 (pcl813), PCL-813B (pcl813b), [ADLink] ACL-8112DG (acl8112dg),
> + * ACL-8112HG (acl8112hg), ACL-8113 (acl-8113), ACL-8216 (acl8216),
> + * [ICP] ISO-813 (iso813), A-821PGH (a821pgh), A-821PGL (a821pgl),
> + * A-821PGL-NDA (a821pclnda), A-822PGH (a822pgh), A-822PGL (a822pgl),
> + * A-823PGH (a823pgh), A-823PGL (a823pgl), A-826PG (a826pg)

Please add extra whitespace (a tab or a couple of spaces) to the
"Devices:" continuation lines here, e.g.:

 * Devices: [Advantech] PCL-812 (pcl812), PCL-812PG (pcl812pg),
 *   PCL-813 (pcl813), PCL-813B (pcl813b), [ADLink] ACL-8112DG (acl8112dg),
 *   ACL-8112HG (acl8112hg), ACL-8113 (acl-8113), ACL-8216 (acl8216),
 *   [ICP] ISO-813 (iso813), A-821PGH (a821pgh), A-821PGL (a821pgl),
 *   A-821PGL-NDA (a821pclnda), A-822PGH (a822pgh), A-822PGL (a822pgl),
 *   A-823PGH (a823pgh), A-823PGL (a823pgl), A-826PG (a826pg)

This extra whitespace is for the benefit of some scripts we have in
comedi and comedilib for extracting the documentation.  (Actually, these
scripts don't handle the " * " at the beginning of the line yet, but I'm
working on that!)

Thanks.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/