linux-kernel - Re: [PATCH] uniform cdrom: fix mutex unlocking in /proc/sys/dev/cdrom/info file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100614123417.444a82c3.akpm@linux-foundation.org>
Date:	Mon, 14 Jun 2010 12:34:17 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	dave.bueso@...il.com
Cc:	axboe@...nel.dk, jens.axboe@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uniform cdrom: fix mutex unlocking in
 /proc/sys/dev/cdrom/info file

On Wed, 09 Jun 2010 12:56:50 -0400
Davidlohr Bueso <dave.bueso@...il.com> wrote:

> If the last if condition passes the cdrom_mutex mutex will not be unlocked. 
> This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label.
> 

Confused.  There is no way in which cdrom_sysctl_info() can forget to
unlock cdrom_mutex.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/