linux-kernel - Re: [PATCH] ipmi: Make sure drivers were registered before unregistering them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100614204701.GA32612@srcf.ucam.org>
Date:	Mon, 14 Jun 2010 21:47:01 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	minyard@....org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: Make sure drivers were registered before
	unregistering them

On Mon, Jun 14, 2010 at 01:36:08PM -0700, Andrew Morton wrote:
> On Thu, 10 Jun 2010 13:53:26 -0400
> Matthew Garrett <mjg@...hat.com> wrote:
> 
> > The ipmi code will never register a PCI or Open Firmware driver if
> > a hardcoded device is provided by the user.
> 
> How does a user "provide a hardcoded device"?

By providing device addresses via the module parameters. This is the 
terminology used in the driver.

> I tried to work out from the above whether we want to backport this fix
> into -stable and failed.  And I reckon that if I can't work this out
> from a changelog, the changelog is inadequate.

We don't. The change that caused this bug was merged post-.34.

> >  #ifdef CONFIG_ACPI
> > @@ -3330,6 +3338,7 @@ static __devinit int init_ipmi_si(void)
> >  
> >  #ifdef CONFIG_PPC_OF
> >  	of_register_platform_driver(&ipmi_of_platform_driver);
> > +	of_registered = 1;
> 
> I assume the code will still oops if of_register_platform_driver() failed.

Indeed. I should fix that.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/