linux-kernel - Re: [PATCH] max730x: make pullups configurable via platformdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100615082121.GA2478@pengutronix.de>
Date:	Tue, 15 Jun 2010 10:21:21 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] max730x: make pullups configurable via platformdata

On Tue, Jun 15, 2010 at 10:01:01AM +0200, Marc Kleine-Budde wrote:
> The gpios on the max730x chips have support for internal pullups
> while in input mode.
> 
> This patch adds support for configuring these pullups via platform data.
> A new member ("input_pullup_active") to the platform data struct is
> introduced. A set bit in this variable activates the pullups while the
> respective port is in input mode. This is a compatible enhancement since
> unset bits lead to disables pullups which was the default in the
> original driver.
> 
> _Note_: the 4 lowest bits in "input_pullup_active" are unused because
> the first 4 ports of the controller are not used, too.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

Marc an I already discussed the previous versions, so:

Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)