[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTil7b5Pg5q18eGvGY_cFH75rdpSuZhigH4vcjrnu@mail.gmail.com>
Date: Tue, 15 Jun 2010 20:39:43 +0900
From: Jassi Brar <jassisinghbrar@...il.com>
To: Maurus Cuelenaere <mcuelenaere@...il.com>
Cc: Kukjin Kim <kgene.kim@...sung.com>,
Linus Walleij <linus.walleij@...ricsson.com>,
Dan Williams <dan.j.williams@...el.com>,
linux-arm-kernel@...ts.infradead.org, yuanyabin1978@...a.com,
Viresh Kumar <viresh.kumar@...com>,
Alessandro Rubini <rubini@...pv.it>,
linux-kernel@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
Peter Pearse <peter.pearse@....com>
Subject: Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081
PrimeCells
On Tue, Jun 15, 2010 at 8:17 PM, Maurus Cuelenaere
<mcuelenaere@...il.com> wrote:
> Op 15-06-10 12:45, Jassi Brar schreef:
>> On Tue, Jun 15, 2010 at 7:25 PM, Kukjin Kim <kgene.kim@...sung.com> wrote:
>>> Linus Walleij wrote:
>>>>
>>>> This creates a DMAengine driver for the ARM PL080/PL081 PrimeCells
>>>> based on the implementation earlier submitted by Peter Pearse.
>>>> This is working like a charm for memcpy on the PB11MPCore, but
>>>> slave DMA to devices is still not working.
>>>>
>>>> This DMA controller is used in mostly unmodified form in the ARM
>>>> RealView and Versatile platforms, in the ST-Ericsson Nomadik, and
>>>> in the ST SPEAr platform.
>>>>
>>>> It has been converted to use the header from the Samsung PL080
>>>> derivate instead of its own defintions, and can potentially support
>>>> several controllers in the same system.
>>>>
>>>> Cc: Peter Pearse <peter.pearse@....com>
>>>> Cc: Ben Dooks <ben-linux@...ff.org>
>>>> Cc: Kukjin Kim <kgene.kim@...sung.com>
>>>
>>> Looks good, but please give me some time to test on the board(SMDK6410).
>>> If any problem, let you know. Of course no problem, will ack.
>> Samsung doesn't use the DMA API, so this driver is unlikely to work.
>
> It doesn't indeed, but it could be adapted to be a wrapper around the DMA engine API.
> Or even better, the drivers could be adapted to use that API.
I don't particularly like the idea of making Samsung's drivers use the DMA API.
IMHO the S3C dma api is better atm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists