linux-kernel - Re: e-SATA ExpressCard - OOPS plus incrementing "ataX" on Linux-2.6.xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimOvFsGZU6Brd-VjzBQGCoP7pgM1rO0wLrZjZZW@mail.gmail.com>
Date:	Tue, 15 Jun 2010 08:52:44 -0600
From:	Robert Hancock <hancockrwd@...il.com>
To:	Jeff Chua <jeff.chua.linux@...il.com>
Cc:	Jeff Garzik <jgarzik@...hat.com>, Greg KH <greg@...ah.com>,
	kristen.c.accardi@...el.com, Dely Sy <dely.l.sy@...el.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Matthew Wilcox <willy@...com>
Subject: Re: e-SATA ExpressCard - OOPS plus incrementing "ataX" on 
	Linux-2.6.xx

On Tue, Jun 15, 2010 at 6:08 AM, Jeff Chua <jeff.chua.linux@...il.com> wrote:
> On Tue, Jun 15, 2010 at 7:49 AM, Robert Hancock <hancockrwd@...il.com> wrote:
>
>> The ataX number incrementing is normal (it always increments when an ATA
>> host is initialized, it doesn't appear the numbers get reused). The other
>> messages are the expected result when you surprise-remove the card. I think
>> there should be a way to trigger the hotplug code to disable the device
>> before you eject it, but I'm not sure what that is supposed to be - maybe
>> echo 1 to /sys/device/pci_somethingorother/remove ?
>
> Robert,
>
> Thanks for the pointer. I found this "remove" is in
> /sys/bus/pci/devices/0000:05:00.0/remove
>
> # echo 1 >/sys/bus/pci/devices/0000:05:00.0/remove
>
> ata14.00: disabled
> sd 17:0:0:0: [sdb] Synchronizing SCSI cache
> sd 17:0:0:0: [sdb] Result: hostbyte=0x04 driverbyte=0x00
> sd 17:0:0:0: [sdb] Stopping disk
> sd 17:0:0:0: [sdb] START_STOP FAILED
> sd 17:0:0:0: [sdb] Result: hostbyte=0x04 driverbyte=0x00
> ahci 0000:05:00.0: PCI INT A disabled
>
>
> It's getter better. Next is to really shutdown the "sdb" hard disk. Is
> that possible? Would be nice to make the "sd 17:0:0:0: [sdb]
> START_STOP FAILED" go away gracefully. Any command to do that?

Try echoing 1 to the file for the SCSI disk's "delete" file, something
like: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/delete

>
>
> On Tue, Jun 15, 2010 at 9:26 AM, Jeff Garzik <jeff@...zik.org> wrote:
>
>> The incrementing of ataX is unrelated to anything else...  Each "new" ata interface gets a new id.
>
> Jeff,
>
> With the "remove" command working, it'll be nice to make "ahci"
> _reuse_ the interface now that it's removed cleanly. I'm just afaid
> that each time the card is removed and reinserted, the ataXX interface
> kept incrementing and will eventually does harm to the kernel?

I don't think so, it's just a number used to associate debug output
for the device. I suppose if you did it 2 billion times it might wrap
negative but even that would just be cosmetic..

>
>
>> "failed to stop engine" is where the driver is attempting to talk to the card, and gracefully shut things down.  > If the card does not exist (ie. has been removed/ejected), then this is normal behavior.
>
> Ok, that's fixed with "echo 1 >/sys/bus/pci/devices/0000:05:00.0/remove".
>
>
>
> Thanks,
> Jeff
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/