linux-kernel - Re: [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100615153116.GD3967@swordfish.minsk.epam.com>
Date:	Tue, 15 Jun 2010 18:31:16 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Jiri Slaby <jslaby@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] avoid using smp_processor_id() in preemptible code
 (nr_iowait_cpu)

On (06/15/10 18:23), Sergey Senozhatsky wrote:
>....
> 		delta = ktime_sub(now, ts->idle_entrytime);
> 		ts->idle_sleeptime = ktime_add(ts->idle_sleeptime, delta);
> 		if (nr_iowait_cpu(cpu) > 0)
> 			ts->iowait_sleeptime = ktime_add(ts->iowait_sleeptime, delta);
> 		put_cpu();
> 		ts->idle_entrytime = now;
> +		ts->idle_active = 0;
		^^^^^^

This part is wrong. Sorry.

> 	}
> 
> 	if (last_update_time)
> 		*last_update_time = ktime_to_us(now);
> 
> }

Content of type "application/pgp-signature" skipped