linux-kernel - Re: [PATCH 02/12] irq: make spurious poll timer per desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C17AB91.1040207@kernel.org>
Date:	Tue, 15 Jun 2010 18:34:25 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	mingo@...e.hu, tglx@...utronix.de, bphilips@...e.de,
	yinghai@...nel.org, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	jeff@...zik.org, linux-ide@...r.kernel.org,
	stern@...land.harvard.edu, gregkh@...e.de, khali@...ux-fr.org
Subject: Re: [PATCH 02/12] irq: make spurious poll timer per desc

On 06/15/2010 07:10 AM, Konrad Rzeszutek Wilk wrote:
>> @@ -169,6 +170,7 @@ struct irq_2_iommu;
>>   * @pending_mask:	pending rebalanced interrupts
>>   * @threads_active:	number of irqaction threads currently running
>>   * @wait_for_threads:	wait queue for sync_irq to wait for threaded handlers
>> + * @poll_timer:		timer for IRQ polling
> 
> I looked over the patches and they all look good to my eyes.
> 
> The only thing that looked out of place was the above comment.
> Would it make sense to move the comment one tab to the left?

When applied, it will show up at the right place.  It's because the
first tab ends next to ':' and the leading '+' ends up pushing it to
the next tab position.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/