linux-kernel - Re: [PATCH] uniform cdrom: fix mutex unlocking in /proc/sys/dev/cdrom/info file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100615123101.5b9addff.akpm@linux-foundation.org>
Date:	Tue, 15 Jun 2010 12:31:01 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	dave.bueso@...il.com
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uniform cdrom: fix mutex unlocking in
 /proc/sys/dev/cdrom/info file

On Tue, 15 Jun 2010 14:40:54 -0400
Davidlohr Bueso <dave.bueso@...il.com> wrote:

> Regarding cdrom_sysctl_info(), I have noticed in several netbooks
> (haven't
> looked in other machines with no cdrom drive) that the
> /proc/sys/dev/cdrom/info file shows no values for the listed entries,
> ie:
> 
> CD-ROM information, Id: cdrom.c 3.20 2003/12/17
> 
> drive name:
> drive speed:
> drive # of slots:
> Can close tray:
> Can open tray:
> ...
> 
> Now, is this expected behavior? If not, should it be changed to
> something
> more descriptive? Perhaps it would affect user space applications that
> read
> the file?

It works for me.

Does your kernel build have CONFIG_SYSCTL=n?  If so, then all that code
is disabled.  That seems a bit bogus to me and perhaps we should enable
at least some of that code by CONFIG_PROCFS instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/