lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jun 2010 15:52:58 +1000 From: Julian Calaby <julian.calaby@...il.com> To: "Justin P. Mattock" <justinmattock@...il.com> Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, linux-pci@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: [PATCH 0/5] Fix set but unused variable warnings On Wed, Jun 16, 2010 at 15:33, Justin P. Mattock <justinmattock@...il.com> wrote: > Here is another set of patches fixing some warning messages generated > when building the kernel when using gcc 4.6.0. > > This set just focuses in on the variables warnings that are reported > to be unused. Keep in mind there are still lots more warning messages > that I'm seeing, and will try my hardest to see if I can come up with > a fix, but if things become too difficult and so forth then a bug should > be filled etc.. Given that patches 3, 4 and 5 seem to be a cases of missing error handling, (3 and 4 in particular seem to be breaking things rather than fixing them) in my humble opinion, I think this set needs some work and discussion. Justin, maybe you'd be better off posting the actual error messages (split up by subsystem) and letting the lists discuss them, rather than posting patches which are obviously wrong. (like the ones I've pointed out) I'm sure that everyone here is as committed as you are to eliminating compile warnings and errors and, in my opinion, more good will come from a healthy discussion of the warnings than maintainers NAKing your patches out of hand. Thanks, -- Julian Calaby Email: julian.calaby@...il.com .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists