| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jun 2010 18:16:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: alexander.h.duyck@...el.com, jeffrey.t.kirsher@...el.com, mingo@...hat.com, tglx@...utronix.de, hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, gospo@...hat.com Subject: Re: [PATCH net-next-2.6] net: NET_SKB_PAD should depend on L1_CACHE_BYTES From: Eric Dumazet <eric.dumazet@...il.com> Date: Mon, 14 Jun 2010 14:57:14 +0200 > [PATCH net-next-2.6] net: NET_SKB_PAD should depend on L1_CACHE_BYTES > > In old kernels, NET_SKB_PAD was defined to 16. > > Then commit d6301d3dd1c2 (net: Increase default NET_SKB_PAD to 32), and > commit 18e8c134f4e9 (net: Increase NET_SKB_PAD to 64 bytes) increased it > to 64. > > While first patch was governed by network stack needs, second was more > driven by performance issues on current hardware. Real intent was to > align data on a cache line boundary. > > So use max(32, L1_CACHE_BYTES) instead of 64, to be more generic. > > Remove microblaze and powerpc own NET_SKB_PAD definitions. > > Thanks to Alexander Duyck and David Miller for their comments. > > Suggested-by: David Miller <davem@...emloft.net> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists