linux-kernel - Re: [PATCH 02/37] lmb: Prepare x86 to use lmb to replace early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276678107.2552.214.camel@pasglop>
Date:	Wed, 16 Jun 2010 18:48:27 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 02/37] lmb: Prepare x86 to use lmb to replace early_res

On Tue, 2010-06-15 at 22:42 -0700, Yinghai Lu wrote:
> 1. expose lmb_debug
> 2. expose lmb_reserved_init_regions
> 
> -v2: drop lmb_add_region() and LMB_ERROR export
> -v3: seperate wrong return of lmb_fin_base to another patch
> -v4: expose lmb_can_resize to handle x86 EFI that could have more than
>       128 entries

I don't like those too much but I suppose we can go with that for now
and fix things up later.

Ack.

Ben.

> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> ---
>  include/linux/lmb.h |    3 +++
>  lib/lmb.c           |    5 +++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/lmb.h b/include/linux/lmb.h
> index 6f8c4bd..1e96224 100644
> --- a/include/linux/lmb.h
> +++ b/include/linux/lmb.h
> @@ -39,6 +39,9 @@ struct lmb {
>  };
>  
>  extern struct lmb lmb;
> +extern int lmb_debug;
> +extern int lmb_can_resize;
> +extern struct lmb_region lmb_reserved_init_regions[];
>  
>  extern void __init lmb_init(void);
>  extern void __init lmb_analyze(void);
> diff --git a/lib/lmb.c b/lib/lmb.c
> index 13d1a04..bbdb1ec 100644
> --- a/lib/lmb.c
> +++ b/lib/lmb.c
> @@ -22,9 +22,10 @@
>  
>  struct lmb lmb;
>  
> -static int lmb_debug, lmb_can_resize;
> +int lmb_debug;
> +int lmb_can_resize;
>  static struct lmb_region lmb_memory_init_regions[INIT_LMB_REGIONS + 1];
> -static struct lmb_region lmb_reserved_init_regions[INIT_LMB_REGIONS + 1];
> +struct lmb_region lmb_reserved_init_regions[INIT_LMB_REGIONS + 1];
>  
>  #define LMB_ERROR	(~(phys_addr_t)0)
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/