linux-kernel - Re: [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with n_used_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1276702948.6437.17047.camel@nimitz>
Date:	Wed, 16 Jun 2010 08:42:28 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with
 n_used_mmu_pages

On Wed, 2010-06-16 at 11:25 -0300, Marcelo Tosatti wrote:
> > -     if (used_pages > kvm_nr_mmu_pages) {
> > -             while (used_pages > kvm_nr_mmu_pages &&
> > +     if (kvm->arch.n_used_mmu_pages > goal_nr_mmu_pages) {
> > +             while (kvm->arch.n_used_mmu_pages > goal_nr_mmu_pages &&
> >                       !list_empty(&kvm->arch.active_mmu_pages)) {
> >                       struct kvm_mmu_page *page;
> >  
> >                       page = container_of(kvm->arch.active_mmu_pages.prev,
> >                                           struct kvm_mmu_page, link);
> > -                     used_pages -= kvm_mmu_zap_page(kvm, page);
> > -                     used_pages--;
> > +                     kvm->arch.n_used_mmu_pages -= kvm_mmu_zap_page(kvm, page);
> > +                     kvm->arch.n_used_mmu_pages--;
> 
> kvm->arch.n_used_mmu_pages is deaccounted for in kvm_mmu_zap_page ->
> kvm_mmu_free_page
> already.

Ahh, I see that now.  Thanks!

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/