linux-kernel - Re: [PATCH] perf: excluding "." and ".." directories when calculating tids.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C18FD5E.7070809@tabris.net>
Date:	Wed, 16 Jun 2010 09:35:42 -0700
From:	Adam Schrotenboer <adam@...ris.net>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
CC:	mingo@...e.hu,
	linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf: excluding "." and ".." directories when calculating
 tids.

On 06/15/2010 10:21 PM, Gui Jianfeng wrote:
> Introduce a filter function to skip "." and ".." directories when calculating
> tid number.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@...fujitsu.com>
> ---
>  tools/perf/util/thread.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> index 1f7ecd4..9a448b4 100644
> --- a/tools/perf/util/thread.c
> +++ b/tools/perf/util/thread.c
> @@ -7,6 +7,15 @@
>  #include "util.h"
>  #include "debug.h"
>  
> +/* Skip "." and ".." directories */
> +static int filter(const struct dirent *dir)
> +{
> +	if (dir->d_name[0] == '.')
> +		return 0;
> +	else
> +		return 1;
> +}
> +
>   

Is this safe? Can you _never_ have a d_name with a leading dot, like '
.hidden' ??
Maybe should
if(dir->d_name[0] == '.' && (dir->d_name[1] == '\0' || (dir->d_name[1]
== '.' && dir->d_name[2] == '\0')))

Admittedly I don't think it happens in the current procfs, but I'd want
to be careful regardless.



Download attachment "signature.asc" of type "application/pgp-signature" (262 bytes)