linux-kernel - Re: [PATCH] x86: OLPC: add support for calling into OpenFirmware (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C1931CF.6040200@zytor.com>
Date:	Wed, 16 Jun 2010 13:19:27 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andres Salomon <dilinger@...ued.net>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, Mitch Bradley <wmb@...top.org>
Subject: Re: [PATCH] x86: OLPC: add support for calling into OpenFirmware
 (v3)

On 06/16/2010 12:13 PM, Andres Salomon wrote:
> @@ -658,6 +664,10 @@ ENTRY(stack_start)
>  	.long init_thread_union+THREAD_SIZE
>  	.long __BOOT_DS
>  
> +.globl olpc_ofw_pgd
> +olpc_ofw_pgd:
> +	.long olpc_ofw_pgd
> +
>  ready:	.byte 0
>  

This variable doesn't need to be initialized, and so belongs .bss.  You
don't need to declare it in an assembly file at all; it probably makes
more sense to just declare it a normal variable (possibly __init) inside
olpc_ofw.c.

Otherwise it's starting to look good.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/