linux-kernel - Re: [PATCH 3/3] cxgb4i_v4.3 : main driver files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4C194DD6.7090706@cs.wisc.edu>
Date:	Wed, 16 Jun 2010 17:19:02 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	open-iscsi@...glegroups.com
CC:	Rakesh Ranjan <rakesh@...lsio.com>,
	LK-NetDev <netdev@...r.kernel.org>,
	LK-SCSIDev <linux-scsi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Karen Xie <kxie@...lsio.com>,
	David Miller <davem@...emloft.net>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Anish Bhatt <anish@...lsio.com>
Subject: Re: [PATCH 3/3] cxgb4i_v4.3 : main driver files

On 06/07/2010 11:59 PM, Rakesh Ranjan wrote:
> From: Rakesh Ranjan<rakesh@...lsio.com>
>
>
> Signed-off-by: Rakesh Ranjan<rakesh@...lsio.com>
> ---
>   drivers/scsi/cxgbi/cxgb4i.h         |  175 +++++
>   drivers/scsi/cxgbi/cxgb4i_ddp.c     |  653 ++++++++++++++++
>   drivers/scsi/cxgbi/cxgb4i_init.c    |  317 ++++++++
>   drivers/scsi/cxgbi/cxgb4i_offload.c | 1409 +++++++++++++++++++++++++++++++++++
>   4 files changed, 2554 insertions(+), 0 deletions(-)
>   create mode 100644 drivers/scsi/cxgbi/cxgb4i.h
>   create mode 100644 drivers/scsi/cxgbi/cxgb4i_ddp.c
>   create mode 100644 drivers/scsi/cxgbi/cxgb4i_init.c
>   create mode 100644 drivers/scsi/cxgbi/cxgb4i_offload.c
>

Do you think you can look through this patch and identify the places 
where you basically just copied a cxgb3i function or copied it but 
renamed some stuff and then move these type of things to the lib patch?

A lot of the scatter list stuff for example looks the same in each driver.

ddp_find_unused_entries - cxgb4i_ddp_find_unused_entries
ddp_unmark_entries - cxgb4i_ddp_unmark_entries
cxgb3i_ddp_find_page_index - cxgb4i_ddp_find_page_index
cxgb3i_ddp_adjust_page_table - cxgb4i_ddp_adjust_page_table
..... (lots of the ddp code looks duplicated).

The *_offload.c code looks the same.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/