linux-kernel - RE: [PATCH v3] drivers: regulator: add Maxim 8998 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000601cb0e21$fa1179b0$ee346d10$%szyprowski@samsung.com>
Date:	Thu, 17 Jun 2010 15:35:35 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Cc:	'Liam Girdwood' <lrg@...mlogic.co.uk>,
	'Samuel Ortiz' <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com
Subject: RE: [PATCH v3] drivers: regulator: add Maxim 8998 driver

Hello,

On Wednesday, June 16, 2010 4:31 PM Mark Brown wrote:

> On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.park@...sung.com>
> >
> > This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> > is used on Samsung Aquila and GONI boards and provides following
> > functionalities:
> > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
> >   controllers
> > - battery charger
> >
> > This patch adds basic driver for voltage regulators and MAX 8998 MFD core.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> Looks good!
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

I've just noticed one more thing. Shouldn't the max8998-pmic driver depend
on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd
driver from the regulators Kconfig? What do you think? 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/