linux-kernel - [PATCH] nfsd: make sure all sv_permsocks have lockd references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jun 2010 10:17:45 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	bfields@...ldses.org
Cc:	linux-nfs@...r.kernel.org, chris@...ne.freeserve.co.uk,
	linux-kernel@...r.kernel.org
Subject: [PATCH] nfsd: make sure all sv_permsocks have lockd references

This patchset should apply cleanly to the other patches that I've sent
recently. They fix some (theoretical) problems with the text-based write
ports and nfsd_init_socks interfaces.

The problem is that nfsd_last_thread expects that every socket on
sv_permsocks has a corresponding lockd reference, but there a couple of
ways to get sockets onto that list without getting a lockd reference.

This patch fixes all that I could spot. I suspect that this, along with
the other patches that I proposed earlier will fix the problem that
Chris Vine reported.

I've done some basic smoke testing with them and they seem to work
as expected.

I've also put the entire patch stack in my git tree on kernel.org:

http://git.kernel.org/?p=linux/kernel/git/jlayton/linux.git;a=summary

...in the nfsd-error branch. It may be more convenient to pull them
from there.

Jeff Layton (2):
  nfsd: shut down transport in nfsd_init_socks if no lockd reference
  nfsd: have __write_ports_add/delxprt get/put lockd references for
    transports

 fs/nfsd/nfsctl.c |   59 ++++++++++++++++++++++++++++++++++++++---------------
 fs/nfsd/nfssvc.c |   21 +++++++++++++++---
 2 files changed, 59 insertions(+), 21 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/