linux-kernel - Re: [PATCH 12/31] tty: serial - fix tty back references in termios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100617202113.GA20666@suse.de>
Date:	Thu, 17 Jun 2010 13:21:13 -0700
From:	Greg KH <gregkh@...e.de>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Frederic Weisbecker <fweisbec@...il.com>,
	John Kacur <jkacur@...hat.com>, Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 12/31] tty: serial - fix tty back references in termios

On Thu, Jun 17, 2010 at 11:50:57AM -0700, Tony Luck wrote:
> A couple of build breaks in linux-next (tag: next-20100617)
> 
> drivers/serial/ioc4_serial.c:1750: error: expected statement before ‘)’ token
> 
> Would have a similar one for ioc3_serial.c if my .config included it.
> 
> On Tue, Jun 1, 2010 at 1:52 PM, Arnd Bergmann <arnd@...db.de> wrote:
> > diff --git a/drivers/serial/ioc3_serial.c b/drivers/serial/ioc3_serial.c
> > index f164ba4..bd2e9e6 100644
> > --- a/drivers/serial/ioc3_serial.c
> > +++ b/drivers/serial/ioc3_serial.c
>  ...
> > -       if (I_IGNPAR(state->port.tty))
> > +       if (iflag & IGNPAR))
> 
> Can we have matching numbers of "(" and ")" here please.
> 
> > diff --git a/drivers/serial/ioc4_serial.c b/drivers/serial/ioc4_serial.c
> > index 8ad28fc..2c30023 100644
> > --- a/drivers/serial/ioc4_serial.c
> > +++ b/drivers/serial/ioc4_serial.c
>  ..
> .-               if (I_IGNPAR(state->port.tty))
> +               if (iflag & IGNPAR))
> 
> Same here.

I've fixed these up in my tree so the next linux-next will contain the
correct ones.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/