linux-kernel - Re: [PATCH] checkpatch: fix false positive on casting to double pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTilrWSOoias64UGAnkV1RtIkVKiwapCnOYc2cS0_@mail.gmail.com>
Date:	Fri, 18 Jun 2010 14:15:35 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	"Scott J. Goldman" <scottjg@...are.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: fix false positive on casting to double 
	pointer

On Thu, Jun 17, 2010 at 9:26 PM, Scott J. Goldman <scottjg@...are.com> wrote:
>
> Signed-off-by: Scott J. Goldman <scottjg@...are.com>
> ---
>  scripts/checkpatch.pl         |    4 +++-
>  tests/t/t9190-double-pointers |    6 ++++++
>  2 files changed, 9 insertions(+), 1 deletions(-)
>  create mode 100644 tests/t/t9190-double-pointers
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 87bbb8b..687bd6f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1982,7 +1982,9 @@ sub process {
>                                         $op eq '*' or $op eq '/' or
>                                         $op eq '%')
>                                {
> -                                       if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
> +                                       if ($op eq '*' && $cc =~ /^\*/) {
> +                                               # double pointer is ok
> +                                       } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
>                                                ERROR("need consistent spacing around '$op' $at\n" .
>                                                        $hereptr);

Hrm, I would expect any number of levels of pointers to be detected
already correctly.

/me goes check.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/