linux-kernel - Re: [PATCH] ath5k: disable ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276870309.23783.3.camel@maxim-laptop>
Date:	Fri, 18 Jun 2010 17:11:49 +0300
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Bob Copeland <me@...copeland.com>
Cc:	Jussi Kivilinna <jussi.kivilinna@...et.fi>,
	ath5k-devel@...ts.ath5k.org, linux-wireless@...r.kernel.org,
	"Luis R. Rodriguez" <mcgrof@...badil.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ath5k: disable ASPM

On Fri, 2010-06-18 at 09:59 -0400, Bob Copeland wrote: 
> On Fri, Jun 18, 2010 at 7:05 AM, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> >> Patch I made uses GPL code from e1000e, but since ath5k is
> >> dual-licensed so patch can't be accepted. So if I got it right, patch
> >> has to be remade from scratch by someone who really knows about pci
> >> registers etc. I don't, and learning this to fix something that is
> >> already fixed in my point of view is waste of (my) time.
> > Sure, regardless of licensing, this patch has to be redone (and e1000
> > with it)
> 
> At any rate, Jussi, thanks a bundle for tracking it down.  I owe you a
> beer, lots of bugs have been reported on these devices.
> 
> Maxim, this device was always broken in the same way, right?  Just
> curious if anything made it worse recently.

Always was broken, of course even with madwifi.

Recently I think driver stopped doing reset on RXORN, which sometimes
helped. This did made things a bit worse.

Anyway, just disable L0S, and card works perfectly.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/