linux-kernel - RE: [PATCH] checkpatch: fix false positive on casting to double pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F78BCF638F95D74A99D036114107EDB50235BBE9B3@EXCH-MBX-3.vmware.com>
Date:	Fri, 18 Jun 2010 09:11:27 -0700
From:	Scott Goldman <scottjg@...are.com>
To:	Andy Whitcroft <apw@...onical.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] checkpatch: fix false positive on casting to double
 	pointer

> > Hrm, I would expect any number of levels of pointers to be detected
> > already correctly.
> >
> > /me goes check.
>
> We already have tests for both types which are passing generally, in
> t730-* and t7020-* so I think this is more likely a failure to detect
> the type as a type.  If you could send on the sample that triggers
> this I will have a look.
> 
> -apw

Yikes! you're right, lousy tests on my part. The part of my patch that triggered it was:
+  return snmp_fold_field((void __percpu **)net->mib.udp_statistics,
+           UDP_MIB_RCVBUFERRORS) +
+     snmp_fold_field((void __percpu **)net->mib.udplite_statistics,
+           UDP_MIB_RCVBUFERRORS);


ERROR: need consistent spacing around '*' (ctx:WxO)
#115: FILE: drivers/net/vmxnet3/vmxnet3_drv.c:1784:
+       return snmp_fold_field((void __percpu **)net->mib.udp_statistics,
                                              ^
Maybe caused by the __percpu attr?--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/