linux-kernel - Re: [PATCH] serial: cpm_uart: implement the cpm_uart_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C1AE0CE.3040901@windriver.com>
Date:	Fri, 18 Jun 2010 10:58:22 +0800
From:	DDD <dongdong.deng@...driver.com>
To:	Greg KH <gregkh@...e.de>
CC:	Greg KH <greg@...ah.com>, jason.wessel@...driver.com,
	galak@...nel.crashing.org, bruce.ashfield@...driver.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: cpm_uart: implement the cpm_uart_early_write()
 function for console poll

Greg KH wrote:
> On Fri, Jun 18, 2010 at 10:10:48AM +0800, DDD wrote:
>> Greg KH wrote:
>>> On Thu, Jun 17, 2010 at 11:13:40AM +0800, Dongdong Deng wrote:
>>>> The cpm_uart_early_write() function which was used for console poll
>>>> isn't implemented in the cpm uart driver.
>>>>
>>>> Implementing this function both fixes the build and allows
>>>> kgdboc to work via the cpm uart.
>>> So this is needed for the .35 release, right?  Any older kernel releases
>>> as well?
>> Yes, it is needed for the .35 release.
>>
>> The cpm_uart_early_write() of cpm_uart was introduced at 2.6.27,
>> so this patch is needed from 2.6.27.
> 
> So no one has noticed that the driver doesn't build at all since the .27
> kernel release?  Over 2 years?  I hardly think that it's a rush to fix
> it over the next few weeks then :)
>

Hi greg,

The build error just happens when enable the CONFIG_CONSOLE_POLL option.

> I'll go queue it up.

Thanks,

Dongdong

> 
> thanks,
> 
> greg k-h
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/