linux-kernel - [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006182221.57333.rjw@sisk.pl>
Date:	Fri, 18 Jun 2010 22:21:57 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Dave Airlie <airlied@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	"dri-devel" <dri-devel@...ts.freedesktop.org>,
	linux-pm@...ts.linux-foundation.org,
	Alex Deucher <alexdeucher@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ondrej Zary <linux@...nbow-software.org>
Subject: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

From: Rafael J. Wysocki <rjw@...k.pl>

I have recently noticed a 55 sec. delay during the "device freeze"
phase of hibernation on my test-bed HP nx6325.  Due to the 100%
reproducibility of it I was able to narrow it down to
radeon_suspend_kms() and then it turned out that the delay occured
somewhere in radeon_bo_evict_vram().  However, it doesn't seem really
necessary or even very useful to me to evict VRAM at this particular
point, because we're going to create an image and bring the device
back to the fully functional state in a little while.  Thus, I think
the VRAM evicition can be skipped for state.event == PM_EVENT_FREEZE,
which makes the delay go away.

Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
---
 drivers/gpu/drm/radeon/radeon_device.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/gpu/drm/radeon/radeon_device.c
===================================================================
--- linux-2.6.orig/drivers/gpu/drm/radeon/radeon_device.c
+++ linux-2.6/drivers/gpu/drm/radeon/radeon_device.c
@@ -750,8 +750,11 @@ int radeon_suspend_kms(struct drm_device
 			}
 		}
 	}
-	/* evict vram memory */
-	radeon_bo_evict_vram(rdev);
+
+	if (state.event != PM_EVENT_FREEZE) {
+		/* evict vram memory */
+		radeon_bo_evict_vram(rdev);
+	}
 	/* wait for gpu to finish processing current batch */
 	radeon_fence_wait_last(rdev);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/