linux-kernel - Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze phase of hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276895296.6513.3.camel@t60prh>
Date:	Sat, 19 Jun 2010 07:08:16 +1000
From:	Dave Airlie <airlied@...hat.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-kernel@...r.kernel.org,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-pm@...ts.linux-foundation.org,
	Alex Deucher <alexdeucher@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ondrej Zary <linux@...nbow-software.org>
Subject: Re: [PATCH] DRM / radeon / PM: Do not evict VRAM during freeze
 phase of hibernation

On Fri, 2010-06-18 at 22:21 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> I have recently noticed a 55 sec. delay during the "device freeze"
> phase of hibernation on my test-bed HP nx6325.  Due to the 100%
> reproducibility of it I was able to narrow it down to
> radeon_suspend_kms() and then it turned out that the delay occured
> somewhere in radeon_bo_evict_vram().  However, it doesn't seem really
> necessary or even very useful to me to evict VRAM at this particular
> point, because we're going to create an image and bring the device
> back to the fully functional state in a little while.  Thus, I think
> the VRAM evicition can be skipped for state.event == PM_EVENT_FREEZE,
> which makes the delay go away.

I'm not 100% sure of the hibernate sequencing and its early in the
morning, but we want to evict VRAM before image building so we can have
the contents of VRAM in the image so we can restore them on resume. Does
this just avoid evicting them a second time after we created the image?

Dave.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/