linux-kernel - Re: [PATCH] remove pointless debug printk in rt_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100618231513.GB17831@kroah.com>
Date:	Fri, 18 Jun 2010 16:15:13 -0700
From:	Greg KH <greg@...ah.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Giangiacomo Mariotti <giangiacomo.mariotti@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	bzolnier@...il.com, roel.kluin@...il.com,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()

On Sat, Jun 05, 2010 at 12:07:39PM +0200, Arnd Bergmann wrote:
> On Saturday 05 June 2010, Giangiacomo Mariotti wrote:
> > This debug printk is only useful if you're debugging the staging drivers
> > 2860 e 2870, but, if you're just using them, it becomes really annoying, because
> > it uselessly clobbers the kernel log. I guess this patch shouldn't really get merged,
> > but it's more like a request to remove these annoying debugging messages for normal users.
> > If I get any suggestion on how to implement this in a way acceptable to get it merged, I'll
> > be happy to create the "good" version  of the patch.
> 
> Ideally, drivers should not have their own debugging macros like this, but
> instead use the kernel's own pr_debug() and (preferrably) dev_dbg() macros,
> which are disabled by default.
> For many of these debugging outputs, it's even better to kill them entirely
> instead of converting to dev_dbg().
> Do not put the line in comments though.

I agree, just use dev_dbg() instead.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/