[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100617231902.9ce1e33e.akpm@linux-foundation.org>
Date: Thu, 17 Jun 2010 23:19:02 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Borislav Petkov <bp@...64.org>
Cc: Dan Carpenter <error27@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [patch] get rid of "cut here" from bug output
On Thu, 17 Jun 2010 14:36:37 +0200 Borislav Petkov <bp@...64.org> wrote:
> From: Dan Carpenter <error27@...il.com>
> Date: Thu, Jun 17, 2010 at 02:21:56PM +0200
>
> > It's annoying to have chunks of dmesg output instead just the whole
> > output. A lot of times the very interesting information is before
> > the bug happens.
> >
> > Signed-off-by: Dan Carpenter <error27@...il.com>
> >
> > diff --git a/kernel/panic.c b/kernel/panic.c
> > index 3b16cd9..2db532a 100644
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -373,7 +373,7 @@ static void warn_slowpath_common(const char *file, int line, void *caller,
> > {
> > const char *board;
> >
> > - printk(KERN_WARNING "------------[ cut here ]------------\n");
> > + printk(KERN_WARNING "-----[ paste whole dmesg to bugzilla ]-----\n");
>
> Good idea, we end up requesting the whole dmesg most of the time anyway.
> However not all bugs are reported through bugzilla, and, frankly
> bugzilla is kinda sucky when it comes down to communicating with the bug
> reporter. How about the more generic "send whole dmesg when reporting"
> instead?
And the pestiferous thing wordwraps the dmesg output to death, making
it amazingly hard to read. s/paste/attach/ maybe.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists