linux-kernel - Re: [RFC 1/3] Unified NMI delayed call mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100619105352.GA10186@elte.hu>
Date:	Sat, 19 Jun 2010 12:53:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	huang ying <huang.ying.caritas@...il.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Huang Ying <ying.huang@...el.com>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Don Zickus <dzickus@...hat.com>,
	"H.PeterA" <"nvin hpa"@zytor.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/3] Unified NMI delayed call mechanism

( Ugh: what's this new fad of you not quoting the name of the person who 
  wrote a mail? It makes multi-level quotes utterly unreadable as it's not
  clear who wrote what. You should also respect others by quoting their names. )

* Andi Kleen <andi@...stfloor.org> wrote:

> > > we can use soft_irq as a backup of self interrupt (for systems without 
> > > APIC and maybe for other architectures).
> > 
> > Whatever would you want to do that for.
> 
> The idea is that the work would be done latest on the next timer interrupt 
> as a fallback if APIC is not available.

Abusing the timer irq for that is an exceedingly ugly and unacceptable design, 
as machine check events have nothing to do with timers. (That approach is also 
buggy because it inserts an arbitrary delay - which could be rather long on 
nohz.)

This kind of messy, ad-hoc piggybacking only creates unmaintainable code in 
the long run.

> That's what mce does already and it's probably approbiate for most other 
> users too.

Hell no, the unfortunate and unclean practices of the MCE code must not be 
propagated elsewhere.

The proper, generic approach would be to enable softirq notifications (on x86) 
from NMI contexts as well (it's actually possible without overhead), and to 
extend user return notifiers with the logical next step: nmi return notifiers. 
If presented in such a form then those could use softirqs for atomic callbacks 
and per cpu kthreads for sleepable callbacks, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/