linux-kernel - [PATCH v3] ath5k: disable ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 19 Jun 2010 18:32:44 +0300
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Bob Copeland <me@...copeland.com>
Cc:	Jussi Kivilinna <jussi.kivilinna@...et.fi>,
	ath5k-devel@...ts.ath5k.org, linux-wireless@...r.kernel.org,
	"Luis R. Rodriguez" <mcgrof@...badil.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH v3] ath5k: disable ASPM

On Sat, 2010-06-19 at 16:02 +0300, Maxim Levitsky wrote: 
> On Sat, 2010-06-19 at 08:38 -0400, Bob Copeland wrote: 
> > On Sat, Jun 19, 2010 at 10:49:34AM +0300, Maxim Levitsky wrote:
> > > How this patch?
> > 
> > Looks fine to me.  Some nitpicking below but feel free to add my
> > 
> > Acked-by: Bob Copeland <me@...copeland.com>
> > 
Done.

Best regards,
Maxim Levitsky

--- 

commit 616afa397b3e843f2aba06be12a30e72dfff7740
Author: Maxim Levitsky <maximlevitsky@...il.com>
Date:   Thu Jun 17 23:21:42 2010 +0300

    ath5k: disable ASPM
    
    Atheros card on Acer Aspire One (AOA150, Atheros Communications Inc. AR5001
    Wireless Network Adapter [168c:001c] (rev 01)) doesn't work well with ASPM
    enabled. With ASPM ath5k will eventually stall on heavy traffic with often
    'unsupported jumbo' warnings appearing. Disabling ASPM L0s in ath5k fixes
    these problems.
    Also card sends a storm of RXORN interrupts even though medium is idle.
    
    Reproduced with pcie_aspm=force and by using 'nc < /dev/zero > /dev/null' at
    both ends (usually stalls within seconds).
    
    Unfortunately BIOS enables ASPM on this card by default on these machines
    This means that, problem shows up (less often) without pcie_aspm=force too. 
    Therefore to benefit from this fix you need to _enable_ CONFIG_PCIEASPM
    

    All credit for this patch goes to Jussi Kivilinna <jussi.kivilinna@...et.fi>
    for finding and fixing this bug.
    
    Based on patch that is
    From: Jussi Kivilinna <jussi.kivilinna@...et.fi>
    
    
    Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
    Acked-by: Bob Copeland <me@...copeland.com>

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 3abbe75..4f6bd7c 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -48,6 +48,7 @@
 #include <linux/netdevice.h>
 #include <linux/cache.h>
 #include <linux/pci.h>
+#include <linux/pci-aspm.h>
 #include <linux/ethtool.h>
 #include <linux/uaccess.h>
 #include <linux/slab.h>
@@ -469,6 +470,19 @@ ath5k_pci_probe(struct pci_dev *pdev,
 	int ret;
 	u8 csz;
 
+	/*
+	 * Disable PCIE ASPM L0S on the card.
+	 * ASPM triggers hardware bug, that makes card stall transmission
+	 * untill reset, and even that doesn't always help.
+	 * This happens on meduim to heavy transmit utilization.
+	 * In addition to stall, hardware usually gives a storm of
+	 * RXORN interrupts, despite idle channel, and otherwise doesn't work.
+	 * Windows driver also disables the L0s ASPM,
+	 * probably due to same reason
+	 * Note: to benefit from this fix, please _enable_ CONFIG_PCIEASPM
+	 */
+	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S);
+
 	ret = pci_enable_device(pdev);
 	if (ret) {
 		dev_err(&pdev->dev, "can't enable device\n");


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/