[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4C1CE5CE.9090807@zytor.com>
Date: Sat, 19 Jun 2010 08:44:14 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Andi Kleen <andi@...stfloor.org>
CC: mingo@...hat.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
hpa@...ux.intel.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/build] x86, vdso: Error out if the vdso contains external
references
On 06/19/2010 12:27 AM, Andi Kleen wrote:
>> diff --git a/arch/x86/vdso/checkundef.sh b/arch/x86/vdso/checkundef.sh
>> new file mode 100755
>> index 0000000..490be1c
>> --- /dev/null
>> +++ b/arch/x86/vdso/checkundef.sh
>> @@ -0,0 +1,10 @@
>> +#!/bin/sh
>> +nm="$1"
>> +file="$2"
>> +"$nm" "$file" | grep '^ *U' > /dev/null 2>&1
>
> Does that really handle the failed inline, static function case?
>
> In this case you get a function which is not 'U', but it's
> just in the wrong section. I think that would need to be checked too.
>
Makes sense.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists