linux-kernel - Re: [PATCH, RFC] block: don't allocate a payload for discard request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100619042534.GA16217@redhat.com>
Date:	Sat, 19 Jun 2010 00:25:34 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Christoph Hellwig <hch@....de>
Cc:	axboe@...nel.dk, martin.petersen@...cle.com,
	James.Bottomley@...e.de, linux-kernel@...r.kernel.org,
	dm-devel@...hat.com
Subject: Re: [PATCH, RFC] block: don't allocate a payload for discard request

On Fri, Jun 18 2010 at 10:59am -0400,
Christoph Hellwig <hch@....de> wrote:

> 
> Allocating a fixed payload for discard requests always was a horrible hack,
> and it's not coming to byte us when adding support for discard in DM/MD.
> 
> So change the code to leave the allocation of a payload to the lowlevel
> driver.  Unfortunately that means we'll need another hack, which allows
> us to update the various block layer length fields indicating that we
> have a payload.  Instead of hiding this in sd.c, which we already partially
> do for UNMAP support add a documented helper in the core block layer for it.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Mike Snitzer <snitzer@...hat.com>

I've built on your patch to successfully implement discard support for
DM (this includes splitting discards that span targets; only the linear
and striped DM targets are supported so far).

The patchset is still a work in progress but is available here (against
2.6.34 at the moment):
http://people.redhat.com/msnitzer/patches/dm-discard/latest/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/