linux-kernel - Re: [PATCH 1/2] Staging: comedi: fix style errors in adl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100620200238.GA31748@fujitsu>
Date:	Sun, 20 Jun 2010 13:02:39 -0700
From:	Charles Clément <caratorn@...il.com>
To:	John Sheehan <john.d.sheehan@...il.com>
Cc:	Charles Clément <caratorn@...il.com>,
	gregkh@...e.de, wfp5p@...ginia.edu, rich.folsom@...il.com,
	mithlesh@...syssoft.com, jirislaby@...il.com,
	john.d.sheehan@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: fix style errors in adl_pci9111.c

On Thu, Jun 17, 2010 at 10:33:36AM +0100, John Sheehan wrote:
> Hi Charles,
> 
> 2010/6/16 Charles Clément <caratorn@...il.com>:
> > Hi,
> >
> > On Wed, Jun 16, 2010 at 07:30:09PM +0100, John Sheehan wrote:
> >> From: John Sheehan <john.d.sheehan@...il.com>
> >
> >> @@ -190,7 +190,7 @@ TODO:
> >>    outb(flags, PCI9111_IO_BASE+PCI9111_REGISTER_TRIGGER_MODE_CONTROL)
> >>
> >>  #define pci9111_interrupt_and_fifo_get() \
> >> -  ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4) &0x03)
> >> +  ((inb(PCI9111_IO_BASE+PCI9111_REGISTER_AD_MODE_INTERRUPT_READBACK) >> 4)&0x03)
> >
> > Doesn't checkpatch.pl suggest to add a whitespace after the & in that case?
> 
> no, surprisingly enough, it just requires the amount of whitespace at
> either side of the & to be consistent

Any specific reason to take this off the list?

> 
> John
> > It would seem more readable.
> >
> > --
> > Charles Clément
> >
> >

-- 
Charles Clément

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/