linux-kernel - Re: wait_for_completion_interruptible does not wait !! [During PM suspend]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C1DC883.7090009@gmail.com>
Date:	Sun, 20 Jun 2010 09:51:31 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Suresh Rajashekara <suresh.raj+linuxomap@...il.com>
CC:	linux-omap@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: wait_for_completion_interruptible does not wait !! [During PM
 suspend]

On 06/20/2010 09:42 AM, Suresh Rajashekara wrote:
> On Sun, Jun 20, 2010 at 12:23 AM, Jiri Slaby <jirislaby@...il.com> wrote:
>> On 06/20/2010 08:52 AM, Suresh Rajashekara wrote:
>>> The ioctl waits on a completion variable (using
>>> wait_for_completion_interruptible).
>> ...
>>> I tried wait_for_completion instead, but now the kernel refuses to suspend.
>>
>> Do you check return value of wait_for_completion_interruptible and
>> return its value if nonzero?
>>
>> We need the code to comment, otherwise it's hard to say.
> 
> No. I am not checking the return value of the
> wait_for_completion_interruptible. I can do it

I thought so. Generally, all *_interruptible functions return a value
which should be checked and propagated to upper layers.

-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/