linux-kernel - Re: [rtc-linux] [PATCH v3] RTC: Add JZ4740 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1D6F34.5050703@gmail.com>
Date:	Sun, 20 Jun 2010 09:30:28 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	rtc-linux@...glegroups.com, Ralf Baechle <ralf@...ux-mips.org>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Paul Gortmaker <p_gortmaker@...oo.com>
Subject: Re: [rtc-linux] [PATCH v3] RTC: Add JZ4740 RTC driver

Lars-Peter Clausen :
> Wan ZongShun wrote:
>>> This patch adds support for the RTC unit on JZ4740 SoCs.
>>>
>>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
>>> Cc: Alessandro Zummo <a.zummo@...ertech.it>
>>> Cc: Paul Gortmaker <p_gortmaker@...oo.com>
>>> Cc: rtc-linux@...glegroups.com
>>>
>>> -- 
>>> Changes since v1
>>> - Use dev_get_drvdata directly instead of wrapping it in dev_to_rtc
>>> - Add common implementation for jz4740_rtc_{alarm,update}_irq_enable
>>> - Check whether rtc structure could be allocated
>>> - Remove deadlocks which could occur if the HW was broken
>>>
>>> Changes since v2
>>> - Use kzalloc instead of kmalloc
>>> - Propagate errors in jz4740_rtc_reg_write up to its callers
>> Acked-by: Wan ZongShun <mcuos.com@...il.com>
>>
>> Andrew, the v3 patch has fixed some above issues, it looks good to me
>> now.
>> Could you please consider merging it to your git tree?
>>
> Hi
> 
> As written in the introduction mail to this thread it would be good if
> the majority of the patches could go through Ralfs tree.
> So if the patch is good an "Acked-by:" would be preferable.
> 
Okay, Sound like good to me, please do you want to do.
Acked-by: Wan ZongShun <mcuos.com@...il.com>

> Thanks,
> - Lars
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/