linux-kernel - Re: [PATCH 3/6]cifs Fix variable not set warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1E1602.7080700@alessandroguido.name>
Date:	Sun, 20 Jun 2010 15:22:10 +0200
From:	Alessandro Guido <ag@...ssandroguido.name>
To:	"Justin P. Mattock" <justinmattock@...il.com>
CC:	linux-kernel@...r.kernel.org, zippel@...ux-m68k.org,
	linux-fsdevel@...r.kernel.org, rusty@...tcorp.com.au,
	linux-audit@...hat.com
Subject: Re: [PATCH 3/6]cifs Fix variable not set warnings

> ...
> @@ -734,7 +733,6 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
>   			direntry->d_op =&cifs_dentry_ops;
>   		d_add(direntry, newInode);
>   		if (posix_open)
> -			filp = lookup_instantiate_filp(nd, direntry, NULL);
>   		/* since paths are not looked up by component - the parent
>   		   directories are presumed to be good here */
>   		renew_parental_timestamps(direntry);
> ...

This is wrong, now "renew_parental_timestamps(direntry)" is in the if body.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/