linux-kernel - Re: [PATCH 3/6 v3]cifs Fix warnings variables set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100620214225.2cd9fc65@corrin.poochiereds.net>
Date:	Sun, 20 Jun 2010 21:42:25 -0400
From:	Jeff Layton <jlayton@...ba.org>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	linux-cifs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6 v3]cifs Fix warnings variables set but not used

On Sun, 20 Jun 2010 18:23:21 -0700
"Justin P. Mattock" <justinmattock@...il.com> wrote:

> Below is a redu from the original(or similar) fixing
> gcc warningds generated while compiling:
> 
>   CC [M]  fs/cifs/cifssmb.o
> fs/cifs/cifssmb.c: In function 'CIFSSMBSetFileSize':
> fs/cifs/cifssmb.c:4855:8: warning: variable 'data_offset' set but not used
>  
>   CC [M]  fs/cifs/file.o
> fs/cifs/file.c: In function 'cifs_partialpagewrite':
> fs/cifs/file.c:1315:23: warning: variable 'pTcon' set but not used
> 
> (the warning below is funky i.g. removing pTcon generates the warning below
> but if I use the __unused option there is no warning at all).
> 
>  CC [M]  fs/cifs/file.o
> fs/cifs/file.c: In function 'cifs_partialpagewrite':
> fs/cifs/file.c:1314:23: warning: variable 'cifs_sb' set but not used
> 
>  Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
> 
> ---
>  fs/cifs/cifssmb.c |    3 ---
>  fs/cifs/file.c    |    4 ----
>  2 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index c65c341..4653aaa 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -4852,7 +4852,6 @@ CIFSSMBSetFileSize(const int xid, struct cifsTconInfo *tcon, __u64 size,
>  		   __u16 fid, __u32 pid_of_opener, bool SetAllocation)
>  {
>  	struct smb_com_transaction2_sfi_req *pSMB  = NULL;
> -	char *data_offset;
>  	struct file_end_of_file_info *parm_data;
>  	int rc = 0;
>  	__u16 params, param_offset, offset, byte_count, count;
> @@ -4876,8 +4875,6 @@ CIFSSMBSetFileSize(const int xid, struct cifsTconInfo *tcon, __u64 size,
>  	param_offset = offsetof(struct smb_com_transaction2_sfi_req, Fid) - 4;
>  	offset = param_offset + params;
>  
> -	data_offset = (char *) (&pSMB->hdr.Protocol) + offset;
> -
>  	count = sizeof(struct file_end_of_file_info);
>  	pSMB->MaxParameterCount = cpu_to_le16(2);
>  	/* BB find exact max SMB PDU from sess structure BB */
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 75541af..661f868 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -1311,8 +1311,6 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
>  	char *write_data;
>  	int rc = -EFAULT;
>  	int bytes_written = 0;
> -	struct cifs_sb_info *cifs_sb;
> -	struct cifsTconInfo *pTcon;
>  	struct inode *inode;
>  	struct cifsFileInfo *open_file;
>  
> @@ -1320,8 +1318,6 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
>  		return -EFAULT;
>  
>  	inode = page->mapping->host;
> -	cifs_sb = CIFS_SB(inode->i_sb);
> -	pTcon = cifs_sb->tcon;
>  
>  	offset += (loff_t)from;
>  	write_data = kmap(page);

Looks good to me.

Reviewed-by: Jeff Layton <jlayton@...ba.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/