linux-kernel - Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and CFQ_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100621145016.GA4259@redhat.com>
Date:	Mon, 21 Jun 2010 10:50:16 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>, Divyesh Shah <dpshah@...gle.com>
Subject: Re: [PATCH] cfq-iosched: Fixed boot warning with BLK_CGROUP=y and
 CFQ_GROUP_IOSCHED=n

On Mon, Jun 21, 2010 at 09:05:17AM +0200, Ingo Molnar wrote:
> 
> * Vivek Goyal <vgoyal@...hat.com> wrote:
> 
> > On Sun, Jun 20, 2010 at 10:10:16AM +0200, Ingo Molnar wrote:
> > > 
> > > * Vivek Goyal <vgoyal@...hat.com> wrote:
> > > 
> > > > Hi Jens,
> > > > 
> > > > Few days back Ingo noticed a CFQ boot time warning. This patch fixes it.
> > > 
> > > Hm, have you tested it? This bit:
> > 
> > I did compile and boot testing. Booted with CFQ_GROUP_IOSCHED=n to make
> > sure warning seen by you is gone. [...]
> 
> It was not a build warning, it was a build failure. (Even if it built the 
> recursion would cause a crash on bootup.) Will try your newer patch too.

I think compiler is doing some optimizations. On my system, it just
compiles fine and even boots fine. But when I introduce a trace_printk(),
statement in the function, then compilation is fine but system hangs
during boot.

I am using gcc version 4.4.4 20100503.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/