[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1277141434.17092.17.camel@c-dwalke-linux.qualcomm.com>
Date: Mon, 21 Jun 2010 10:30:34 -0700
From: Daniel Walker <dwalker@...eaurora.org>
To: Gregory Bean <gbean@...eaurora.org>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3 v2] msm: Add gpio register address mapping
information.
On Sat, 2010-06-19 at 09:29 -0700, Gregory Bean wrote:
> +#if defined(CONFIG_ARCH_MSM7X30)
> +#define GPIO1_REG(off) (MSM_GPIO1_BASE + (off))
> +#define GPIO2_REG(off) (MSM_GPIO2_BASE + 0x400 + (off))
> +#else
> +#define GPIO1_REG(off) (MSM_GPIO1_BASE + 0x800 + (off))
> +#define GPIO2_REG(off) (MSM_GPIO2_BASE + 0xC00 + (off))
> +#endif
> +
> +#if defined(CONFIG_ARCH_QSD8X50)
> +#include "gpio_hw-8x50.h"
> +#elif defined(CONFIG_ARCH_MSM7X30)
> +#include "gpio_hw-7x30.h"
> +#else
> +#include "gpio_hw-7xxx.h"
> +#endif
I don't think this compiles for 7xxx , since your adding the ifdef block
but not the header.. It would be nice to also include that.
don't respin till the license thing is settled ..
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists