linux-kernel - Re: [PATCH] x86/mrst/pci: avoid enabling intx for msi capable devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100621121253.478dfffc@virtuousgeek.org>
Date:	Mon, 21 Jun 2010 12:12:53 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Moblin Kernel <moblin-kernel@...ux.intel.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH] x86/mrst/pci: avoid enabling intx for msi capable
 devices

On Mon, 21 Jun 2010 12:01:30 -0700
"H. Peter Anvin" <hpa@...or.com> wrote:

> Jesse: are you taking this or should I?
> 
> 	-hpa
> 
> On 06/21/2010 11:30 AM, Jacob Pan wrote:
> > On Moorestown platform, true PCI devices with MSI capabilities do not support
> > INTx mode. IRQ line# for those devices are zeros in the PCI shim, an attempt
> > to enable INTx on these MSI capable devices will cause conflict in the system
> > such as IRQ0 for the system timers.
> > If the device driver probes/enables MSI before pci_enable_device(), the conflict
> > is not shown since INTx will be disabled. But if the driver tries to enable INTx
> > before MSI, the conflict will cause system timer IRQ0 to break.
> > 
> > This patch will ensure the ordering of INTx and MSI setup by the driver is
> > not relavent to INTx conflict. We will always skip INTx setup for MSI capable
> > devices on Moorestown.

You go ahead.  You can add my:

Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/