linux-kernel - Re: [PATCH 1/2] firewire: core: no need to track irq flags in bm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100622093618.GC26304@frolo.macqel>
Date:	Tue, 22 Jun 2010 11:36:18 +0200
From:	Philippe De Muyter <phdm@...qel.be>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] firewire: core: no need to track irq flags in
	bm_work

On Mon, Jun 21, 2010 at 11:23:52PM +0200, Stefan Richter wrote:
> This is a workqueue job and always entered with IRQs enabled.

did you mean 'disabled' ?

Philippe

> 
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> ---
>  drivers/firewire/core-card.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> Index: b/drivers/firewire/core-card.c
> ===================================================================
> --- a/drivers/firewire/core-card.c
> +++ b/drivers/firewire/core-card.c
> @@ -239,7 +239,6 @@ static void fw_card_bm_work(struct work_
>  	struct fw_card *card = container_of(work, struct fw_card, work.work);
>  	struct fw_device *root_device, *irm_device;
>  	struct fw_node *root_node;
> -	unsigned long flags;
>  	int root_id, new_root_id, irm_id, local_id;
>  	int gap_count, generation, grace, rcode;
>  	bool do_reset = false;
> @@ -247,10 +246,10 @@ static void fw_card_bm_work(struct work_
>  	bool root_device_is_cmc;
>  	bool irm_is_1394_1995_only;
>  
> -	spin_lock_irqsave(&card->lock, flags);
> +	spin_lock_irq(&card->lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/