linux-kernel - Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900

Open Source and information security mailing list archives

Message-ID: <AANLkTinJplJTzj9rqfmpS0ZXwXDTATuNoxgMjL1z5tEv@mail.gmail.com>
Date:	Tue, 22 Jun 2010 17:41:57 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Alessandro Zummo <a.zummo@...ertech.it>,
	Andrew Morton <akpm@...ux-foundation.org>,
	rtc-linux <rtc-linux@...glegroups.com>,
	LKML <linux-kernel@...r.kernel.org>, dale@...nsworth.org
Subject: Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for 
	max6900

Signed-off-by: Wan ZongShun <mcuos.com@...il.com>

> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
>  drivers/rtc/rtc-max6900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
>                      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
>        tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
>
> -       return 0;
> +       return rtc_valid_tm(tm);
>  }
>
>  static int max6900_i2c_clear_write_protect(struct i2c_client *client)
> --
> 1.6.3.3
>


-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives